[
https://issues.apache.org/jira/browse/HDFS-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451120#comment-13451120
]
Aaron T. Myers commented on HDFS-3896:
--------------------------------------
Hey Jeff, latest patch looks better. Thanks for addressing my comments.
I didn't intend to suggest that you should remove the "if the port is 0..."
from everywhere in the file, but rather just from the NN http-address
description. Thinking about it more, however, I think this is probably a good
change as well. Does anyone have any thoughts on that?
Two more little comments on the patch:
# I should've noticed this before, but this patch actually introduces a second
instance of dfs.namenode.http-address in hdfs-default.xml, even though it's
already present. We should only have one instance.
# The patch doesn't cleanly apply to trunk. Please upload a patch against
trunk, and hit the "Submit patch" button so that Jenkins runs once you've done
so.
> Add place holder for dfs.namenode.rpc-address and
> dfs.namenode.servicerpc-address to hdfs-default.xml
> -----------------------------------------------------------------------------------------------------
>
> Key: HDFS-3896
> URL: https://issues.apache.org/jira/browse/HDFS-3896
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 2.0.0-alpha
> Reporter: Jeff Lord
> Assignee: Jeff Lord
> Priority: Minor
> Attachments: hdfs-default-1.patch, hdfs-default.patch
>
>
> Currently there are mentions of these properties in the docs but not much
> else.
> Would make sense to have empty place holders in hdfs-default.xml to clarify
> where they go and what they are.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
