[
https://issues.apache.org/jira/browse/HDFS-3913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13452444#comment-13452444
]
Andy Isaacson commented on HDFS-3913:
-------------------------------------
Also from HDFS-3828,
bq. note that printBlockReport and getNextBPScanner do not check for null so
they will NPE and we should fix them. Also, looks like the test checks the
return value to see if the scanners are initialized yet.
> Refactor DataBlockScanner and clean up tests
> --------------------------------------------
>
> Key: HDFS-3913
> URL: https://issues.apache.org/jira/browse/HDFS-3913
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 2.0.1-alpha
> Reporter: Andy Isaacson
> Priority: Minor
>
> In HDFS-3828 Eli observed
> bq. In getTotalScans rather than throw IOE if given a bpid w/o a scanner I
> believe this should be an assert (we should always have a scanner for a block
> pool if we've enbabled scanning, which we have if we're in DataBlockScanner)
> and Andy suggested
> bq. we could propagate a "please wake me up at time T" up from
> BlockPoolSliceScanner to DataBlockScanner#run and adjust the sleep time
> there, accordingly. If all threadpools continue to have work to do, then
> preserve the existing 5-second sleep; if all threadpools are done working
> then DataBlockScanner could go to sleep for much longer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
