[ 
https://issues.apache.org/jira/browse/HDFS-2656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453368#comment-13453368
 ] 

Todd Lipcon commented on HDFS-2656:
-----------------------------------

Hey Suresh. Not speaking for Colin, but regarding my comment above: I thought 
this JIRA was committed rather abruptly. Since the patch was quite big (6kloc), 
and there had only been one or two small review comments by Nicholas above (in 
which he said "I just have checked the read code."), I thought the patch was 
still preliminary and there would be more time to review.

Since it's in contrib, I don't think we need to revert it for more review, but 
I do think it makes sense to continue to improve and address people's comments 
in a follow-up JIRA. Do you think it would be better to revert the patch and 
address the commentary?

Maybe we should have some kind of policy that, for large patches like this, 
committers should wait a day or two between giving a +1 and committing, in case 
others want to review? I don't think it's really necessary, but maybe it's 
better than post-commit review in a followup, or asking for a revert in the 
same JIRA.
                
> Implement a pure c client based on webhdfs
> ------------------------------------------
>
>                 Key: HDFS-2656
>                 URL: https://issues.apache.org/jira/browse/HDFS-2656
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: webhdfs
>            Reporter: Zhanwei.Wang
>            Assignee: Jing Zhao
>             Fix For: 2.0.3-alpha
>
>         Attachments: HDFS-2656.patch, HDFS-2656.patch, HDFS-2656.patch, 
> HDFS-2656.unfinished.patch, teragen_terasort_teravalidate_performance.png
>
>
> Currently, the implementation of libhdfs is based on JNI. The overhead of JVM 
> seems a little big, and libhdfs can also not be used in the environment 
> without hdfs.
> It seems a good idea to implement a pure c client by wrapping webhdfs. It 
> also can be used to access different version of hdfs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to