[ 
https://issues.apache.org/jira/browse/HDFS-3664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453590#comment-13453590
 ] 

Colin Patrick McCabe commented on HDFS-3664:
--------------------------------------------

bq. Not your change but in BlockManager we should check datanodeManager and 
blocksMap for null like we do pendingReplications right?

Hmm.  All of those fields are declared {{final}} and unconditionally 
initialized to something non-null in the constructor, so I don't think there 
should be any null checks in the {{close}} function.  I'll post a patch in a 
sec.
                
> BlockManager race when stopping active services
> -----------------------------------------------
>
>                 Key: HDFS-3664
>                 URL: https://issues.apache.org/jira/browse/HDFS-3664
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 2.0.0-alpha
>            Reporter: Eli Collins
>            Assignee: Colin Patrick McCabe
>         Attachments: HDFS-3664.001.patch, HDFS-3664.002.patch
>
>
> Looks like there's a race hit by the test where we try to do block management 
> while shutting down (eg allocate a block or compute replication work after 
> BlocksMap#close, resulting in an NPE).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to