[ 
https://issues.apache.org/jira/browse/HDFS-3924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455328#comment-13455328
 ] 

Aaron T. Myers commented on HDFS-3924:
--------------------------------------

The latest patch looks pretty good to me. My only suggestion is to either get 
rid of HdfsVolumeId#toString entirely, or have it print out the Base64 encoding 
of the identifier. Returning the toString() of a byte[] isn't very helpful - it 
just uses the Object#toString() method.
                
> Multi-byte id in HdfsVolumeId
> -----------------------------
>
>                 Key: HDFS-3924
>                 URL: https://issues.apache.org/jira/browse/HDFS-3924
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs client
>    Affects Versions: 2.0.3-alpha
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>         Attachments: hdfs-3924-1.patch, hdfs-3924-2.patch
>
>
> Currently, the {{id}} in {{HdfsVolumeId}} is just a single byte. It'd be nice 
> to make this larger, for situations where there's a large number of disks.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to