[ 
https://issues.apache.org/jira/browse/HDFS-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457826#comment-13457826
 ] 

Daryn Sharp commented on HDFS-3939:
-----------------------------------

+1 Looks like simple enough changes.  You might consider breaking out the 
{{NNRpcServer#join}} change to another jira but they are a few pretty simple 
lines so it's up to you.
                
> NN RPC address cleanup
> ----------------------
>
>                 Key: HDFS-3939
>                 URL: https://issues.apache.org/jira/browse/HDFS-3939
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 2.0.0-alpha
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Minor
>         Attachments: hdfs-3939.txt, hdfs-3939.txt
>
>
> Most callers to NN#getNameNodeAddress wrap it in NetUtils#getHostPortString 
> or manually create the host:port string. Let's clean that up and the relevant 
> javadocs while we're at it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to