[
https://issues.apache.org/jira/browse/HDFS-3848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458211#comment-13458211
]
Hadoop QA commented on HDFS-3848:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12545609/HDFS-3848-1.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.TestDatanodeBlockScanner
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/3203//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3203//console
This message is automatically generated.
> A Bug in recoverLeaseInternal method of FSNameSystem class
> ----------------------------------------------------------
>
> Key: HDFS-3848
> URL: https://issues.apache.org/jira/browse/HDFS-3848
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.1
> Reporter: Hooman Peiro Sajjad
> Priority: Minor
> Labels: patch
> Attachments: HDFS-3848-1.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This is a bug in logic of the method recoverLeaseInternal. In line 1322 it
> checks if the owner of the file is trying to recreate the file. The condition
> of the if statement is
> (leaseFile != null && leaseFile.equals(lease)) ||
> lease.getHolder().equals(holder)
> As it can be seen, there are two operands (conditions) connected with an "or"
> operator. The first operand is straight and will be true only if the holder
> of the file is the new holder. But the problem is the second operand which
> will be always true since the "lease" object is the one found by the "holder"
> by calling "Lease lease = leaseManager.getLease(holder);" in line 1315.
> To fix this I think the if statement only should contain the following the
> condition:
> (leaseFile != null && leaseFile.getHolder().equals(holder))
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
