[
https://issues.apache.org/jira/browse/HDFS-4035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473952#comment-13473952
]
Hadoop QA commented on HDFS-4035:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12548671/hdfs-4035.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:red}-1 release audit{color}. The applied patch generated 1
release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/3309//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/3309//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3309//console
This message is automatically generated.
> LightWeightGSet and LightWeightHashSet increment a volatile without
> synchronization
> -----------------------------------------------------------------------------------
>
> Key: HDFS-4035
> URL: https://issues.apache.org/jira/browse/HDFS-4035
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: 2.0.0-alpha
> Reporter: Eli Collins
> Assignee: Eli Collins
> Attachments: hdfs-4035.txt
>
>
> LightWeightGSet and LightWeightHashSet have a volatile modification field
> that they use to detect updates while iterating so they can throw a
> ConcurrentModificationException. Since these "LightWeight" classes are
> explicitly "not thread safe" (eg access to their members is not synchronized)
> then the current use is OK, we just need to update findbugsExcludeFile.xml to
> exclude them.
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
