[ 
https://issues.apache.org/jira/browse/HDFS-4036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476150#comment-13476150
 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-4036:
----------------------------------------------

> ... But the issue here doesn't seem to be that we're claiming to throw a ULE 
> when we don't, it's why are we unconditionally swallowing IOEs here w/o so 
> much as a warning? That doesn't seem right.

Eli, I think the reason is that this method is "unprotected".
                
> FSDirectory.unprotectedAddFile(..) should not throw UnresolvedLinkException
> ---------------------------------------------------------------------------
>
>                 Key: HDFS-4036
>                 URL: https://issues.apache.org/jira/browse/HDFS-4036
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 3.0.0
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Jing Zhao
>         Attachments: HDFS-4036-trunk.001.patch
>
>
> The code in FSDirectory.unprotectedAddFile(..) does not throw 
> UnresolvedLinkException, we should remove "throws UnresolvedLinkException" 
> from the declaration.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to