[ 
https://issues.apache.org/jira/browse/HDFS-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suresh Srinivas updated HDFS-4052:
----------------------------------

    Description: Info level log information printed holding the lock is long 
and is printed by traversing a list/array. information (which can be a long msg 
generated by traversing a list/array). It would be better to move them outside 
of the lock.  (was: Currently in branch-1, both 
FSNameSystem#invalidateWorkForOneNode and 
FSNameSystem#computeReplicationWorkForBlock print debug information (which can 
be a long msg generated by traversing a list/array) without releasing the 
FSNameSystem lock. It would be better to move them outside of the namesystem 
lock.

This may also apply to FSNameSystem#invalidateWorkForOneNode in trunk.)
        Summary: BlockManager#invalidateWork should print logs outside the lock 
 (was: FSNameSystem#invalidateWorkForOneNode and 
FSNameSystem#computeReplicationWorkForBlock in branch-1 should print debug 
information outside of the namesystem lock)

Updating the bug summary and description to make it relevant only for trunk. 
Since the description and code is different for 1.x, can you create a separate 
bug?
                
> BlockManager#invalidateWork should print logs outside the lock
> --------------------------------------------------------------
>
>                 Key: HDFS-4052
>                 URL: https://issues.apache.org/jira/browse/HDFS-4052
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 1.2.0, 3.0.0
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>            Priority: Minor
>         Attachments: HDFS-4052.b1.001.patch, HDFS-4052.trunk.001.patch
>
>
> Info level log information printed holding the lock is long and is printed by 
> traversing a list/array. information (which can be a long msg generated by 
> traversing a list/array). It would be better to move them outside of the lock.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to