[ 
https://issues.apache.org/jira/browse/HDFS-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476736#comment-13476736
 ] 

Suresh Srinivas commented on HDFS-4059:
---------------------------------------

Comment:
# Can you please add name and descrption to the metric, some thing like - 
{{@Metric({"StaleDataNodes", "Number of datanodes marked stale due to delayed 
heartbeat"}}}. Without this metric name is derived from the method name and 
will have not descrption.
# Can the test be changed to not wait that long. Also can you avoid dependency 
on timing by using a loop to wait for metric to reach the value?

                
> Add number of stale DataNodes to metrics
> ----------------------------------------
>
>                 Key: HDFS-4059
>                 URL: https://issues.apache.org/jira/browse/HDFS-4059
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: data-node, name-node
>    Affects Versions: 3.0.0
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>            Priority: Minor
>             Fix For: 1.1.0, 3.0.0, 2.0.3-alpha
>
>         Attachments: HDFS-4059.trunk.001.patch
>
>
> Add the number of stale DataNodes to metrics.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to