[
https://issues.apache.org/jira/browse/HDFS-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479896#comment-13479896
]
Hadoop QA commented on HDFS-4002:
---------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12549817/HDFS-4002.patch.trunk
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/3368//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3368//console
This message is automatically generated.
> Tool-ize OfflineImageViewer and make sure it returns proper return codes upon
> exit
> ----------------------------------------------------------------------------------
>
> Key: HDFS-4002
> URL: https://issues.apache.org/jira/browse/HDFS-4002
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: tools
> Affects Versions: 2.0.0-alpha
> Reporter: Harsh J
> Assignee: Stephen Chu
> Priority: Minor
> Labels: newbie
> Fix For: 3.0.0
>
> Attachments: HDFS-4002.patch.trunk
>
>
> We should make OfflineImageViewer structured (code-wise) in the same way as
> OfflineEditsViewer is. Particularly, OIV must implement the Tool interface,
> and must return proper exit codes upon success/failure conditions. Right now,
> it returns 0 in both successful parse and unsuccessful ones.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
