[ 
https://issues.apache.org/jira/browse/HDFS-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480805#comment-13480805
 ] 

Suresh Srinivas commented on HDFS-4079:
---------------------------------------

Nicholas, I have two comments:
# SnapshotManager could be an interface. That way if we need we can make it 
pluggable perhaps in the future. This we could do in a separate jira.
# Second comment is to make for the existing classes such as INode where we are 
changing the access/visibility of methods, we should do it in trunk first. I am 
okay to make it in trunk and then merge it into this branch later.

+1 for the patch.
                
> Add SnapshotManager
> -------------------
>
>                 Key: HDFS-4079
>                 URL: https://issues.apache.org/jira/browse/HDFS-4079
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h4079_20121019.patch
>
>
> SnapshotManager maintains a list for all the snapshottable directories in the 
> namespace.  It also supports snapshot related methods such as setting a 
> directory to snapshottable, creating a snapshot, etc.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to