[
https://issues.apache.org/jira/browse/HDFS-4078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481562#comment-13481562
]
Aaron T. Myers commented on HDFS-4078:
--------------------------------------
I would really have preferred to see some automated tests included with this
change, as an incorrect implementation of this could result in data loss from
snapshots. At least, a follow-up JIRA should be filed to add some automated
tests for this functionality.
In general I've seen a bunch of the commits to the HDFS-2802 branch include no
automated tests whatsoever. I realize that it's sometimes difficult to write
automated tests at the beginning of a big project, before all of the
scaffolding is in place, but I hope that there's a plan to have comprehensive
test coverage of this work.
> Handle replication in snapshots
> -------------------------------
>
> Key: HDFS-4078
> URL: https://issues.apache.org/jira/browse/HDFS-4078
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Labels: needs-test
> Fix For: Snapshot (HDFS-2802)
>
> Attachments: h4078_20121021.patch
>
>
> Without snapshots, file replication is the same as block replication.
> With snapshot, the file replication R_o of the original file and the file
> replication R_s of the snapshot file could possibly be different. Since the
> blocks are shared between the original file and the snapshot file, block
> replication is max(R_o, R_s). If there are more than one snapshots, block
> replication is the max file replication of the original file and all snapshot
> files.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
