[
https://issues.apache.org/jira/browse/HDFS-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482125#comment-13482125
]
Suresh Srinivas commented on HDFS-4084:
---------------------------------------
Comments:
# When you are overriding, no need to add javadoc to the method if you plan on
inheriting changes from the super class. So javadoc for DistributedFileSystem
methods you have added can be deleted.
# Why are you adding @VisibleForTesting for snapshot related methods in
FSNamesystem. Also please proper javadoc to the methods.
# FSNamesystem.java is unnecessarily importing SnapshotInfo?
# NamenodeRpcServer.java remove comment "Client Protocol" for overridden
protocol methods
> provide CLI support for allow and disallow snapshot on a directory
> ------------------------------------------------------------------
>
> Key: HDFS-4084
> URL: https://issues.apache.org/jira/browse/HDFS-4084
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs client, name-node, tools
> Affects Versions: Snapshot (HDFS-2802)
> Reporter: Brandon Li
> Assignee: Brandon Li
> Labels: needs-test
> Attachments: HDFS-4084.patch, HDFS-4084.patch
>
>
> To provide CLI support to allow snapshot, disallow snapshot on a directory.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
