[ 
https://issues.apache.org/jira/browse/HDFS-4105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482755#comment-13482755
 ] 

Arpit Gupta commented on HDFS-4105:
-----------------------------------

no tests are added as changes are related to secure setup.

here is the test patch output for branch-1

{code}
[exec] BUILD SUCCESSFUL
     [exec] Total time: 5 minutes 0 seconds
     [exec] 
     [exec] 
     [exec] 
     [exec] 
     [exec] -1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
     [exec]                         Please justify why no tests are needed for 
this patch.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning 
messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
     [exec] 
     [exec]     -1 findbugs.  The patch appears to introduce 9 new Findbugs 
(version 1.3.9) warnings.
{code}

Findbugs warnings are not related to this patch.
                
> the SPNEGO user for secondary namenode should use the web keytab
> ----------------------------------------------------------------
>
>                 Key: HDFS-4105
>                 URL: https://issues.apache.org/jira/browse/HDFS-4105
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 1.1.0, 2.0.2-alpha
>            Reporter: Arpit Gupta
>            Assignee: Arpit Gupta
>         Attachments: HDFS-4105.branch-1.patch, HDFS-4105.patch
>
>
> This is similar to HDFS-3466 where we made sure the namenode checks for the 
> web keytab before it uses the namenode keytab.
> The same needs to be done for secondary namenode as well.
> {code}
> String httpKeytab = 
>               conf.get(DFSConfigKeys.DFS_SECONDARY_NAMENODE_KEYTAB_FILE_KEY);
>             if (httpKeytab != null && !httpKeytab.isEmpty()) {
>               params.put("kerberos.keytab", httpKeytab);
>             }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to