[
https://issues.apache.org/jira/browse/HDFS-4112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484675#comment-13484675
]
Hadoop QA commented on HDFS-4112:
---------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12550910/h4112_20121025b.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/3401//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3401//console
This message is automatically generated.
> A few improvements on INodeDirectory
> ------------------------------------
>
> Key: HDFS-4112
> URL: https://issues.apache.org/jira/browse/HDFS-4112
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h4112_20121025b.patch, h4112_20121025c.patch,
> h4112_20121025.patch
>
>
> Below are a few improvements on INodeDirectory
> - Add a utility method for casting from INode;
> - avoid creating new empty list and INode arrays;
> - renames getChildren() and getChildrenRaw(), rewrite the javadoc.
> Also,
> - clean up isDirEmpty(..) and isEmpty() in FSDirectory
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
