[ 
https://issues.apache.org/jira/browse/HDFS-4101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486448#comment-13486448
 ] 

Todd Lipcon commented on HDFS-4101:
-----------------------------------

nit: capitalize "ForTests" instead of "Fortests"

- The magic numbers 9998 and 9999 are pretty messy and hard to follow. Instead, 
perhaps add an integer member to the test class such as 
"numZkConnectFailuresToInject"? Then in one of the new cases, you can set it to 
3, and in the other, to 1?

                
> ZKFC should implement zookeeper.recovery.retry like HBase to connect to 
> ZooKeeper
> ---------------------------------------------------------------------------------
>
>                 Key: HDFS-4101
>                 URL: https://issues.apache.org/jira/browse/HDFS-4101
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: auto-failover, ha
>    Affects Versions: 2.0.0-alpha, 3.0.0
>         Environment: running CDH4.1.1
>            Reporter: Damien Hardy
>            Assignee: Damien Hardy
>            Priority: Minor
>              Labels: newbie
>         Attachments: HDFS-4101-2.patch
>
>
> When zkfc start and zookeeper is not yet started ZKFC fails and stop directly.
> Maybe ZKFC should allow some retries on Zookeeper services like does HBase 
> with zookeeper.recovery.retry
> This particularly appends when I start my whole cluster on VirtualBox for 
> example (every components nearly at the same time) ZKFC is the only that fail 
> and stop ... 
> Every others can wait each-others some time independently of the start order 
> like NameNode/DataNode/JournalNode/Zookeeper/HBaseMaster/HBaseRS so that the 
> system can be set and stable in few seconds

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to