[ 
https://issues.apache.org/jira/browse/HDFS-4141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489289#comment-13489289
 ] 

Suresh Srinivas commented on HDFS-4141:
---------------------------------------

Really neat javadoc for Diff.

Minor nits:
"find the corresponding inode in previous" - what is previous? Quite a few 
places the comment just says previous - instead, previous snapshot or previous 
state would read more clearer. Also please add description at the method level 
on what the test does, especially the method runDiffTest. This will help in 
understanding the test better.

                
> Directory diff in snapshots
> ---------------------------
>
>                 Key: HDFS-4141
>                 URL: https://issues.apache.org/jira/browse/HDFS-4141
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h4141_20121101.patch
>
>
> With snapshots, the same directory could have different states, e.g. 
> different sets of children, in different snapshots.  We implement a directory 
> diff algorithm in this JIRA.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to