[ 
https://issues.apache.org/jira/browse/HDFS-4143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tsz Wo (Nicholas), SZE updated HDFS-4143:
-----------------------------------------

    Attachment: h4143_20121102.patch

> ... I think some code depends on the string format so that subclasses cannot 
> override it. ...

This seems not true.

h4143_20121102.patch: removes final from INode.toString().

Since it is the only difference with the last patch, I will commit it without 
waiting from Jerkins.
                
> Change INodeFile.blocks to private
> ----------------------------------
>
>                 Key: HDFS-4143
>                 URL: https://issues.apache.org/jira/browse/HDFS-4143
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>         Attachments: h4143_20121101.patch, h4143_20121102.patch
>
>
> INodeFile.blocks is currently package private.  It is accessed directly in 
> quite many case.  It is better to change it to package private and access via 
> setter and getter methods.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to