[ 
https://issues.apache.org/jira/browse/HDFS-4153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491842#comment-13491842
 ] 

Andy Isaacson commented on HDFS-4153:
-------------------------------------

The patch looks good to me, and I don't think it needs to add a JUnit test.  
But, please copy+paste the output after manually verifying that this generates 
the correct output.
                
> Add START_MSG/SHUTDOWN_MSG for JournalNode
> ------------------------------------------
>
>                 Key: HDFS-4153
>                 URL: https://issues.apache.org/jira/browse/HDFS-4153
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: journal-node
>    Affects Versions: 3.0.0, 2.0.2-alpha
>            Reporter: liang xie
>            Assignee: liang xie
>         Attachments: HDFS-4153.txt
>
>
> Currently, there's no startup/shutdown msg log in jn, it somehow makes a 
> little difficult to digniose issue, we'd better do the same behavior like 
> dn/nn/...
> This tiny patch passed those test cases : 
> -Dtest=org.apache.hadoop.hdfs.qjournal.server.*

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to