[
https://issues.apache.org/jira/browse/HDFS-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492962#comment-13492962
]
Hadoop QA commented on HDFS-4165:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12552588/HDFS-4165.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.web.TestWebHdfsWithMultipleNameNodes
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/3464//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3464//console
This message is automatically generated.
> Faulty sanity check in FsDirectory.unprotectedSetQuota
> ------------------------------------------------------
>
> Key: HDFS-4165
> URL: https://issues.apache.org/jira/browse/HDFS-4165
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Binglin Chang
> Assignee: Binglin Chang
> Priority: Trivial
> Attachments: HDFS-4165.patch
>
>
> According to the documentation:
> The quota can have three types of values : (1) 0 or more will set
> the quota to that value, (2) {@link HdfsConstants#QUOTA_DONT_SET} implies
> the quota will not be changed, and (3) {@link HdfsConstants#QUOTA_RESET}
> implies the quota will be reset. Any other value is a runtime error.
> sanity check in FsDirectory.unprotectedSetQuota should use
> {code}
> nsQuota != HdfsConstants.QUOTA_RESET
> {code}
> rather than
> {code}
> nsQuota < HdfsConstants.QUOTA_RESET
> {code}
> Since HdfsConstants.QUOTA_RESET is defined to be -1, there is not any problem
> for this code, but it is better to do it right.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
