[
https://issues.apache.org/jira/browse/HDFS-4170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496703#comment-13496703
]
Tsz Wo (Nicholas), SZE commented on HDFS-4170:
----------------------------------------------
Thanks for taking a look. It is never too late.
> ... Is a "snapshot path" a path under an already-created snapshot? If so, how
> could it ever be the case that that snapshot might not exist? I think we
> could make this comment a little clearer.
Yes, a snapshot path is supposed to be a path under an already-created
snapshot, e.g. /foo/.snapshot/s1/bar. However, it also includes non-existing
snapshots since paths may be provided by users. They could pass paths
containing non-existing snapshots.
> ... I think it would be a little clearer if we added a
> Snapshot#isNewerThan(Snapshot) method. ...
It sounds like a good idea. The name compareTo was borrowed from the
Comparable interface. It is probably better to define a Comparator for IDs.
> Add snapshot information to INodesInPath
> ----------------------------------------
>
> Key: HDFS-4170
> URL: https://issues.apache.org/jira/browse/HDFS-4170
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: Snapshot (HDFS-2802)
>
> Attachments: h4170_20121108.patch, h4170_20121109.patch
>
>
> For snapshot paths, the snapshot information is required for accessing the
> snapshot.
> For non-snapshot paths, the latest snapshot found in the path is required for
> maintaining diffs for modification.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
