[ https://issues.apache.org/jira/browse/HDFS-4148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498422#comment-13498422 ]
Aaron T. Myers commented on HDFS-4148: -------------------------------------- bq. if this is to add method ensureNotInROSnapshot(INodesInPath) in all the modification related calls, I think getXAndEnsureMutable is cleaner. I disagree, but reasonable people can disagree. bq. FileSystem doesn't have createSysmlink. Yes indeed. That's why I recommend using FileContext. bq. I created a follow-up jira HDFS-4189 to address the feedback. Thanks. I'm watching the JIRA and will review this as soon as you post a patch. > Disallow write/modify operations on files and directories in a snapshot > ------------------------------------------------------------------------ > > Key: HDFS-4148 > URL: https://issues.apache.org/jira/browse/HDFS-4148 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node > Affects Versions: Snapshot (HDFS-2802) > Reporter: Brandon Li > Assignee: Brandon Li > Fix For: Snapshot (HDFS-2802) > > Attachments: HDFS-4148.patch, HDFS-4148.patch, HDFS-4148.patch, > HDFS-4148.patch, HDFS-4148.patch > > > disallow modification on RO snapshots, including create, append, > setReplication/Permission/Owner, rename, delete, makedir, setQuota/Time, > createSymlink. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira