[
https://issues.apache.org/jira/browse/HDFS-3507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498456#comment-13498456
]
Aaron T. Myers commented on HDFS-3507:
--------------------------------------
Hi Vinay, the latest patch looks pretty good to me, except that the current
patch doesn't default the value of the checked field in the .proto file, as I
already commented it should. It should be something like this:
{code}
message SetSafeModeRequestProto {
required SafeModeActionProto action = 1;
+ optional bool checked = 2 [default = false];
}
{code}
> DFS#isInSafeMode needs to execute only on Active NameNode
> ---------------------------------------------------------
>
> Key: HDFS-3507
> URL: https://issues.apache.org/jira/browse/HDFS-3507
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: ha
> Affects Versions: 2.0.0-alpha, 3.0.0
> Reporter: Vinay
> Assignee: Vinay
> Priority: Critical
> Attachments: HDFS-3507.patch, HDFS-3507.patch, HDFS-3507.patch
>
>
> Currently DFS#isInSafeMode is not Checking for the NN state. It can be
> executed on any of the NNs.
> But HBase will use this API to check for the NN safemode before starting up
> its service.
> If first NN configured is in standby then DFS#isInSafeMode will check standby
> NNs safemode but hbase want state of Active NN.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
