[
https://issues.apache.org/jira/browse/HDFS-4200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13499130#comment-13499130
]
Todd Lipcon commented on HDFS-4200:
-----------------------------------
Nice refactoring. Can you please add short javadocs to the new methods? eg
without context, it's not obvious what the 'expected' parameter in
{{sendAckUpstream}} is.
{code}
+ if (!running || !datanode.shouldRun) {
+ break;
+ }
{code}
This bit of code now seems to be in both {{waitForAckHead}} as well as right
after where it's called.
> Reduce the size of synchronized sections in PacketResponder
> ------------------------------------------------------------
>
> Key: HDFS-4200
> URL: https://issues.apache.org/jira/browse/HDFS-4200
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HDFS-4200.patch
>
>
> The size of synchronized sections can be reduced in PacketResponder. Also the
> methods in the PacketResponder are long and need refactoring.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
