[
https://issues.apache.org/jira/browse/HDFS-4209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504294#comment-13504294
]
Suresh Srinivas commented on HDFS-4209:
---------------------------------------
Minor comment: INodeFile#valueOf() unnecessarily throws PathIOException
+1 with that change and Jenkins +1.
> Clean up the addNode/addChild/addChildNoQuotaCheck methods in FSDirectory
> -------------------------------------------------------------------------
>
> Key: HDFS-4209
> URL: https://issues.apache.org/jira/browse/HDFS-4209
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h4209_20121118b.patch, h4209_20121118.patch,
> h4209_20121119.patch, h4209_20121121.patch, h4209_20121126.patch
>
>
> - Returning the same INode back is not useful. It is better to simply return
> a boolean to indicate whether the inode is added.
> - The value of childDiskspace parameter is always UNKNOWN_DISK_SPACE.
> - In most cases, the value of the pos parameter is length - 1.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
