[
https://issues.apache.org/jira/browse/HDFS-3495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505238#comment-13505238
]
Hadoop QA commented on HDFS-3495:
---------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12555113/HDFS-3495-v5.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/3569//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3569//console
This message is automatically generated.
> Update Balancer to support new NetworkTopology with NodeGroup
> -------------------------------------------------------------
>
> Key: HDFS-3495
> URL: https://issues.apache.org/jira/browse/HDFS-3495
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: balancer
> Affects Versions: 1.1.0, 2.0.2-alpha
> Reporter: Junping Du
> Assignee: Junping Du
> Attachments: HADOOP-8473-Balancer-NodeGroup-aware.patch,
> HDFS-3495-v2.patch, HDFS-3495-v3.patch, HDFS-3495-v4.patch, HDFS-3495-v5.patch
>
>
> Since the Balancer is a Hadoop Tool, it was updated to be directly aware of
> four-layer hierarchy instead of creating an alternative Balancer
> implementation. To accommodate extensibility, a new protected method,
> doChooseNodesForCustomFaultDomain is now called from the existing chooseNodes
> method so that a subclass of the Balancer could customize the balancer
> algotirhm for other failure and locality topologies. An alternative option is
> to encapsulate the algorithm used for the four-layer hierarchy into a
> collaborating strategy class.
> The key changes introduced to support a four-layer hierarchy were to override
> the algorithm of choosing <source, target> pairs for balancing. Unit tests
> were created to test the new algorithm.
> The algorithm now makes sure to choose the target and source node on the same
> node group for balancing as the first priority. Then the overall balancing
> policy is: first doing balancing between nodes within the same nodegroup then
> the same rack and off rack at last. Also, we need to check no duplicated
> replicas live in the same node group after balancing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
