[
https://issues.apache.org/jira/browse/HDFS-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508482#comment-13508482
]
Junping Du commented on HDFS-4234:
----------------------------------
Thanks Nicholas. You did a great job to abstract code logic to so simple like
this. The patch looks good to me.
One minor issue (may not be related this patch) is the method name of
isMoveQuotaFull() in Balancer sounds a little misleading (may should be
isMoveQuotaNotFull or something else) to me. What do you think? Anyway, please
feel free to merge in this patch or do it later.
> Use the generic code for choosing datanode in Balancer
> ------------------------------------------------------
>
> Key: HDFS-4234
> URL: https://issues.apache.org/jira/browse/HDFS-4234
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: balancer
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h4234_20121128.patch
>
>
> HDFS-3495 added some generic code for choosing datanodes with NodeGroup
> topology in Balancer. We should reuse the code for choosing datanodes with
> racks.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
