[
https://issues.apache.org/jira/browse/HDFS-4268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konstantin Shvachko updated HDFS-4268:
--------------------------------------
Attachment: heartbeatHAState.patch
The patch removes NNHAStatusHeartbeat.State
and replaces the use of {{instanceof}} to determine the HA state with
determining the actual value of the state.
In few cases when when NN deals with Replication Queues we should actually use
the existing method HAState.shouldPopulateReplQueues().
This is not directly related to BackupNode, but helps to generalize the logic
around it, because BackupState does not extend StandbyState, but has similar
(standby) behavior in most cases.
> Remove redundant enum NNHAStatusHeartbeat.State
> -----------------------------------------------
>
> Key: HDFS-4268
> URL: https://issues.apache.org/jira/browse/HDFS-4268
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Affects Versions: 2.0.2-alpha
> Reporter: Konstantin Shvachko
> Attachments: heartbeatHAState.patch
>
>
> NNHAStatusHeartbeat.State is redundant and can be replaced with commonly used
> enum HAServiceState.
> We should also consistently use HAServiceState to check if the state is
> ACTIVE or STANDBY rather than using {{instanceof}}.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
