[
https://issues.apache.org/jira/browse/HDFS-4261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511158#comment-13511158
]
Aaron T. Myers commented on HDFS-4261:
--------------------------------------
Hey Junping, though not changed by the current patch, can you comment on
whether or not this change to the balancer was correct?
{code}
- if (BlockPlacementPolicy.getInstance(conf, null, null).getClass() !=
- BlockPlacementPolicyDefault.class) {
- throw new UnsupportedActionException("Balancer without
BlockPlacementPolicyDefault");
+ if (BlockPlacementPolicy.getInstance(conf, null, null) instanceof
+ BlockPlacementPolicyDefault) {
+ throw new UnsupportedActionException(
+ "Balancer without BlockPlacementPolicyDefault");
{code}
Whereas before the balancer would throw an error if the BlockPlacementPolicy
was not the default, the balancer will now throw an error if the
BlockPlacementPolicy _is_ the default. That doesn't seem quite right to me, but
perhaps I'm missing something.
I realize this isn't related to this patch per se, but it was committed
recently as a part of HDFS-3495, so perhaps we could address it in this JIRA?
> TestBalancerWithNodeGroup times out
> -----------------------------------
>
> Key: HDFS-4261
> URL: https://issues.apache.org/jira/browse/HDFS-4261
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: balancer
> Affects Versions: 1.0.4, 1.1.1, 2.0.2-alpha
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Junping Du
> Attachments: HDFS-4261.patch, HDFS-4261-v2.patch, HDFS-4261-v3.patch
>
>
> When I manually ran TestBalancerWithNodeGroup, it always timed out in my
> machine. Looking at the Jerkins report [build
> #3573|https://builds.apache.org/job/PreCommit-HDFS-Build/3573//testReport/org.apache.hadoop.hdfs.server.balancer/],
> TestBalancerWithNodeGroup somehow was skipped so that the problem was not
> detected.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
