[
https://issues.apache.org/jira/browse/HDFS-4296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529670#comment-13529670
]
Tsz Wo (Nicholas), SZE commented on HDFS-4296:
----------------------------------------------
+1 patch looks good.
Some optional suggestions:
- We could get rid of specialInit(..) by adding the special feature to the
enum, e.g.
{code}
//LayoutVersion
RESERVED_REL20_203(-31, -19, "Reserved for release 0.20.203", true,
Feature.DELEGATION_TOKEN),
final List<Feature> specialFeatures;
Feature(final int lv, final int ancestorLV, final String description,
boolean reserved, Feature ... specialFeatures) {
this.lv = lv;
this.ancestorLV = ancestorLV;
this.description = description;
this.reserved = reserved;
this.specialFeatures = specialFeatures == null?
Collections.<Feature>emptyList()
: Collections.unmodifiableList(Arrays.asList(specialFeatures));
}
{code}
- getCurrentLayoutVersion() should throw exception outside the for-loop since
all versions are resevered. It indicates a bug in the declaration. Also, the
loop would look better as below
{code}
for (int i = values.length -1; i > 0; i--) {
if (!values[i].isReservedForOldRelease()) {
return values[i].lv;
}
}
throw new AssertionError("All layout versions are reserved.");
{code}
> Add layout version for HDFS-4256 for release 1.2.0
> --------------------------------------------------
>
> Key: HDFS-4296
> URL: https://issues.apache.org/jira/browse/HDFS-4296
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Affects Versions: 3.0.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: lv.patch, lv.patch, lv.patch, lv.patch
>
>
> Backport of concat requires editlog change and incrementing layout version.
> See [this
> comment|https://issues.apache.org/jira/browse/HDFS-4256?focusedCommentId=13525989&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13525989].
> Version number -41 will be reserved for release 1.2.0.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
