[
https://issues.apache.org/jira/browse/HDFS-4033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13546439#comment-13546439
]
Aaron T. Myers commented on HDFS-4033:
--------------------------------------
+1, patch looks good.
> Miscellaneous findbugs 2 fixes
> ------------------------------
>
> Key: HDFS-4033
> URL: https://issues.apache.org/jira/browse/HDFS-4033
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: 2.0.0-alpha
> Reporter: Eli Collins
> Assignee: Eli Collins
> Attachments: hdfs-4033.txt, hdfs-4033.txt
>
>
> Fix some miscellaneous findbugs 2 warnings:
> - Switch statements missing default cases
> - Using \n instead of %n in format methods
> - A socket close that should use IOUtils#closeSocket that we missed
> - A use of SimpleDateFormat that is not threadsafe
> - In ReplicaInputStreams it's not clear that we always close the streams we
> allocate, moving the stream creation into the class where we close them makes
> that more obvious
> - A couple missing null checks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
