[
https://issues.apache.org/jira/browse/HDFS-4377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13548861#comment-13548861
]
Todd Lipcon commented on HDFS-4377:
-----------------------------------
{code}
- // Keeps a TreeSet for every named node. Each treeset contains
+ // Keeps a TreeMap for every named node. Each treeset contains
// a list of the blocks that are "extra" at that location. We'll
// eventually remove these extras.
- // Mapping: StorageID -> TreeSet<Block>
+ // Mapping: StorageID -> TreeMap<Block>
//
public final Map<String, LightWeightLinkedSet<Block>> excessReplicateMap =
new TreeMap<String, LightWeightLinkedSet<Block>>();
{code}
This isn't right -- the value of the map is itself a set, not a map.
----
{code}
- * It is considered extermely rare for all these numbers to match
- * on a different machine accidentally for the following
- * a) SecureRandom(INT_MAX) is pretty much random (1 in 2 billion), and
- * b) Good chance ip address would be different, and
- * c) Even on the same machine, Datanode is designed to use different
ports.
- * d) Good chance that these are started at different times.
- * For a confict to occur all the 4 above have to match!.
- * The format of this string can be changed anytime in future without
- * affecting its functionality.
{code}
I think those comments were useful. Probably worth leaving them as '//' style
comments.
----
Otherwise seems fine
> Some trivial DN comment cleanup
> -------------------------------
>
> Key: HDFS-4377
> URL: https://issues.apache.org/jira/browse/HDFS-4377
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 2.0.0-alpha
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Attachments: hdfs-4377.txt
>
>
> DataStorage.java
> - The "initilized" member is misspelled
> - Comment what the storageID member is
> DataNode.java
> - Cleanup createNewStorageId comment (should mention the port is included and
> is overly verbose)
> BlockManager.java
> - TreeSet in the comment should be TreeMap
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
