[ 
https://issues.apache.org/jira/browse/HDFS-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13552025#comment-13552025
 ] 

Suresh Srinivas commented on HDFS-4098:
---------------------------------------

Comments:
# FSNamesystem.java
#* Please add a comment that for INode in read-only snapshot access time is not 
updated. Optionally move updating access time to a separate method with the 
description of when update is not made.
# FileWithLink.java
#* Based on the javadoc comments alone, I cannot figure out the difference 
between #asFile() and #getNext(). asFile could also move to util, since it need 
not be a method in the interface. Given implementations are returning {{this}} 
for asFile(), I am not sure I understand its functionality.
# FileWithLink#Util needs unit tests. If you want to do it in another jira, 
please create one.

                
> Support append to original files which are snapshotted
> ------------------------------------------------------
>
>                 Key: HDFS-4098
>                 URL: https://issues.apache.org/jira/browse/HDFS-4098
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h4098_20130107.patch, h4098_20130109b.patch
>
>
> When a regular file is reopened for append, the type is changed from 
> INodeFile to INodeFileUnderConstruction.  The type of snapshotted files (i.e. 
> original files) is INodeFileWithLink.  We have to support similar "under 
> construction" INodeFileWithLink.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to