[ 
https://issues.apache.org/jira/browse/HDFS-4350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13560941#comment-13560941
 ] 

Suresh Srinivas commented on HDFS-4350:
---------------------------------------

bq. Suresh, what's our policy on changing config strings and behavior for alpha 
and beta releases? The current name would be misleading, and it'd be kind of 
unfortunate to have to deprecate it already.

I think this is a good change. Out of curiosity, is there a use case for using 
stale datanode information for write path alone (which is what currently not 
supported).

Changing configuration name and semantics will be an incompatible change. I am 
okay making the assumption that this was used only for HBase MTTR work for now 
and make these changes both in branch-2 and branch-2. For branch-1, it is good 
to loop in the release manager [~mattf]. Given 2.0.2 is marked alpha, I am okay 
letting this incompatible change into 2.0.3.

Additionally, related change needs to go into HBase as well, related to 
HBASE-5843. Not sure the backward compatibility impact on HBase.
                
> Make enabling of stale marking on read and write paths independent
> ------------------------------------------------------------------
>
>                 Key: HDFS-4350
>                 URL: https://issues.apache.org/jira/browse/HDFS-4350
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>         Attachments: hdfs-4350-1.patch, hdfs-4350-2.patch, hdfs-4350-3.patch, 
> hdfs-4350-4.patch, hdfs-4350-5.patch, hdfs-4350.txt
>
>
> Marking of datanodes as stale for the read and write path was introduced in 
> HDFS-3703 and HDFS-3912 respectively. This is enabled using two new keys, 
> {{DFS_NAMENODE_CHECK_STALE_DATANODE_KEY}} and 
> {{DFS_NAMENODE_AVOID_STALE_DATANODE_FOR_WRITE_KEY}}. However, there currently 
> exists a dependency, since you cannot enable write marking without also 
> enabling read marking, since the first key enables both checking of staleness 
> and read marking.
> I propose renaming the first key to 
> {{DFS_NAMENODE_AVOID_STALE_DATANODE_FOR_READ_KEY}}, and make checking enabled 
> if either of the keys are set. This will allow read and write marking to be 
> enabled independently.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to