[ 
https://issues.apache.org/jira/browse/HDFS-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tsz Wo (Nicholas), SZE updated HDFS-4441:
-----------------------------------------

    Attachment: h4441_20130125.patch

h4441_20130125.patch:
- Keeps Pair unchanged, i.e. leave it in INode.
- Renames other classes.
- For DEFAULT_ARRAY_INITIAL_CAPACITY, I tried to add /** initial array 
capacity. */ but removed it since the name was already clear about it.
- Also fixes a bug in INode.dumpTreeRecursively(..) that it casts this to 
INodeFileSnapshot but this could be a INodeFileUnderConstructionSnapshot.
{code}
        if (this instanceof INodeFileSnapshot
            || this instanceof INodeFileUnderConstructionSnapshot) {
          out.print(", computedSize="
              + ((INodeFileSnapshot) this).computeFileSize(true));
        }
{code}

                
> Refactor INodeDirectoryWithSnapshot.Diff as a top level generic class
> ---------------------------------------------------------------------
>
>                 Key: HDFS-4441
>                 URL: https://issues.apache.org/jira/browse/HDFS-4441
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h4441_20130124.patch, h4441_20130125.patch
>
>
> INodeDirectoryWithSnapshot.Diff is for recording the difference between the 
> current state and a previous state of the children list of an INodeDirectory. 
>  It is easy to refactor the code to support generic lists.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to