[
https://issues.apache.org/jira/browse/HDFS-4444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13564530#comment-13564530
]
Suresh Srinivas edited comment on HDFS-4444 at 1/28/13 6:56 PM:
----------------------------------------------------------------
+1 for the change. I will commit it shortly.
was (Author: sureshms):
+! for the change. I will commit it shortly.
> Add space between total transaction time and number of transactions in
> FSEditLog#printStatistics
> ------------------------------------------------------------------------------------------------
>
> Key: HDFS-4444
> URL: https://issues.apache.org/jira/browse/HDFS-4444
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 2.0.0-alpha, 3.0.0
> Reporter: Stephen Chu
> Assignee: Stephen Chu
> Priority: Trivial
> Attachments: HDFS-4444.patch.001, HDFS-4444.patch.branch-1
>
>
> Currently, when we log statistics, we see something like
> {code}
> 13/01/25 23:16:59 INFO namenode.FSNamesystem: Number of transactions: 0 Total
> time for transactions(ms): 0Number of transactions batched in Syncs: 0 Number
> of syncs: 0 SyncTimes(ms): 0
> {code}
> Notice how the value for total transactions time and "Number of transactions
> batched in Syncs" needs a space to separate them.
> FSEditLog#printStatistics:
> {code}
> private void printStatistics(boolean force) {
> long now = now();
> if (lastPrintTime + 60000 > now && !force) {
> return;
> }
> lastPrintTime = now;
> StringBuilder buf = new StringBuilder();
> buf.append("Number of transactions: ");
> buf.append(numTransactions);
> buf.append(" Total time for transactions(ms): ");
> buf.append(totalTimeTransactions);
> buf.append("Number of transactions batched in Syncs: ");
> buf.append(numTransactionsBatchedInSync);
> buf.append(" Number of syncs: ");
> buf.append(editLogStream.getNumSync());
> buf.append(" SyncTimes(ms): ");
> buf.append(journalSet.getSyncTimes());
> LOG.info(buf);
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
