[
https://issues.apache.org/jira/browse/HDFS-4339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13566048#comment-13566048
]
Jing Zhao commented on HDFS-4339:
---------------------------------
The new patch looks good. A few more comments:
1. We may remove the unused imports from TestINodeFile.java.
2. The new testcase can be renamed from TestInodeId() to testInodeId() since it
is a method.
3. The cluster and the fsdataoutputstream returned by fs.create need to be
shutdown/closed in the end.
4. In ImageLoaderCurrent.java, for "visit(ImageElement.LAST_INODE_ID,
in.readLong())", we may want to specify the detailed actions in subclasses of
the ImageVisitor (e.g., LsImageVisitor)?
5. In FSImageSerialization.java
{noformat}
if (inodeId > fsNamesys.getLastInodeId()) {
fsNamesys.resetLastInodeId(inodeId);
}
{noformat}
may be unnecessary since the lastInodeId written into fsimage should always be
no less than any inodeId written into the fsimage?
> Persist inode id in fsimage and editlog
> ---------------------------------------
>
> Key: HDFS-4339
> URL: https://issues.apache.org/jira/browse/HDFS-4339
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Affects Versions: 3.0.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Attachments: editsStored, HDFS-4339.patch, HDFS-4339.patch,
> HDFS-4339.patch, HDFS-4339.patch, HDFS-4339.patch
>
>
> Persist inode id in fsimage and editlog and update offline viewers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
