[ 
https://issues.apache.org/jira/browse/HDFS-4464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13569326#comment-13569326
 ] 

Jing Zhao commented on HDFS-4464:
---------------------------------

The name of deleteSubtreeAndCollectBlocks may be a little bit of confusing, 
since when the parameter snapshot is null the function is more like a 
destructor of the subtree. Maybe we can rename the function and make its 
javadoc more clear. 

Besides of that +1 for the patch. 
                
> Combine collectSubtreeBlocksAndClear with deleteDiffsForSnapshot
> ----------------------------------------------------------------
>
>                 Key: HDFS-4464
>                 URL: https://issues.apache.org/jira/browse/HDFS-4464
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h4464_20120201.patch
>
>
> Both collectSubtreeBlocksAndClear and deleteDiffsForSnapshot are recursive 
> methods for deleting inodes and collecting blocks for further block 
> deletion/update.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to