[
https://issues.apache.org/jira/browse/HDFS-4480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13574764#comment-13574764
]
Jing Zhao commented on HDFS-4480:
---------------------------------
The patch looks good. Only some minors:
1. BlocksMapUpdateInfo#addUpdate() is no more useful. I think we can now also
simplify BlocksMapUpdateInfo and FSNamesystem#updateBlocksMap.
2. In TestSnapshot.java, maybe we can use hflush(UPDATE_LENGTH) in
FileAppendNotClose#modify and check the length in the corresponding check.
3. In TestINodeFileUnderConstructionWithSnapshot#testSnapshotAfterAppending,
the last comment ("check the circular list...") needs to be updated.
> Eliminate the file snapshot circular linked list
> ------------------------------------------------
>
> Key: HDFS-4480
> URL: https://issues.apache.org/jira/browse/HDFS-4480
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h4480_20130207.patch
>
>
> With HDFS-4446, all file changes can be recorded using file diff so that the
> circular linked list can be eliminated.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
