[ 
https://issues.apache.org/jira/browse/HDFS-4495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13577962#comment-13577962
 ] 

Hadoop QA commented on HDFS-4495:
---------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12569256/hdfs-4495.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-hdfs-project/hadoop-hdfs.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/3970//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3970//console

This message is automatically generated.
                
> Allow client-side lease renewal to be retried beyond soft-limit
> ---------------------------------------------------------------
>
>                 Key: HDFS-4495
>                 URL: https://issues.apache.org/jira/browse/HDFS-4495
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs-client
>    Affects Versions: 2.0.3-alpha, 0.23.5
>            Reporter: Kihwal Lee
>            Assignee: Kihwal Lee
>         Attachments: hdfs-4495.b023.patch, hdfs-4495.patch, hdfs-4495.patch
>
>
> The current lease renewal code in DFSClient gives up after several retries, 
> if the soft limit exceeds. This causes the client to abort.  Without this 
> self destruction behavior, lease renewal can be retried infinitely due to 
> unrelated low-level issue and prevent DFSClient and associated Connection 
> from getting garbage collected.  
> However, giving up at passage of the soft limit has been shown to be too 
> fragile; A long GC on namenode or transient network outage can make clients 
> fail. We need the self-destruct behavior, but clients should be allowed to 
> retry for longer period of time.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to