[
https://issues.apache.org/jira/browse/HDFS-4479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13578015#comment-13578015
]
Jing Zhao commented on HDFS-4479:
---------------------------------
The simple change passed all the unit tests locally. The test-patch result:
{noformat}
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new
or modified tests.
[exec] Please justify why no tests are needed for
this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] -1 findbugs. The patch appears to introduce 232 new Findbugs
(version 2.0.1) warnings.
{noformat}
> In branch-1, logSync() may be called with the FSNamesystem lock held in
> commitBlockSynchronization
> --------------------------------------------------------------------------------------------------
>
> Key: HDFS-4479
> URL: https://issues.apache.org/jira/browse/HDFS-4479
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 1.2.0
> Reporter: Jing Zhao
> Assignee: Jing Zhao
> Attachments: HDFS-4479.b1.001.patch
>
>
> In FSNamesystem#commitBlockSynchronization of branch-1, logSync() may be
> called when the FSNamesystem lock is held. Similar with HDFS-4186, this may
> cause some performance issue.
> Since logSync is called right after the synchronization section, we can
> simply remove the logSync call.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
