[ 
https://issues.apache.org/jira/browse/HDFS-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13585236#comment-13585236
 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-4514:
----------------------------------------------

- The commands should consistently use either snapshotRoot or snapshotDir.  How 
about using snapshotDir?

- Do not use assert in RenameSnapshot.processArguments(..).  It should throw an 
exception for illegal arguments.

- In SnapshottableDirectoryStatus.print(..), nulls should be printed as empty 
strings.

- Revert the following:
{code}
@@ -267,7 +267,7 @@ public String getCommandName() {
     public void run(Path path) throws IOException {
       dfs.setQuota(path, HdfsConstants.QUOTA_DONT_SET, quota);
     }
-  }
+  }  
   
   /**
{code}

- In LsSnapshottableDir,
-* use FileSystem.get(conf) to get default FileSystem;
-* add javadoc.
                
> Add CLI support for snapshot rename, diff report, and snapshottable directory 
> listing
> -------------------------------------------------------------------------------------
>
>                 Key: HDFS-4514
>                 URL: https://issues.apache.org/jira/browse/HDFS-4514
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>         Attachments: HDFS-4514.000.patch, HDFS-4514.001.patch, Screen Shot 
> 2013-02-22 at 5.38.41 PM.png
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to