[
https://issues.apache.org/jira/browse/HDFS-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13585553#comment-13585553
]
Jing Zhao commented on HDFS-4523:
---------------------------------
The patch looks good to me. The only thought is that in
INodeDirectoryWithSnapshot#removeChildAndAllSnapshotCopies, is it possible that
an inode removed from the created list is actually for a previously deleted
file (but with the same name)? Besides, with the patch TestFSImageWithSnapshot
will fail.
> Fix concat for snapshots
> ------------------------
>
> Key: HDFS-4523
> URL: https://issues.apache.org/jira/browse/HDFS-4523
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h4523_20130222.patch, h4523_20130223.patch
>
>
> The use case of concat is for copying large files across clusters using the
> following steps.
> - Step 1: The blocks of a file in the source cluster are copied in parallel
> to transient files in the destination cluster.
> - Step 2: Then the transient files in the destination cluster are
> concatenated in order to obtain the original file.
> If a snapshot is taken in the destination cluster before Step 2, some
> transient files may be captured in the snapshot. These transient files
> should be removed in Step 2.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
