[ 
https://issues.apache.org/jira/browse/HDFS-4383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13587110#comment-13587110
 ] 

Gelesh commented on HDFS-4383:
------------------------------

There are two para comments, and much of the clause are repeating.
I feel, the older patch ([~neethu pl]'s) was better,
else [~stayhf] , or [~neethu pl] , could you please try some way to have 

/   * For a HDFS client to write to a file, a lease is granted; During the lease
/   * period, no other client can write to the file. The writing client can
/   * periodically renew the lease. When the file is closed, the lease is
/   * revoked. 
/   * The lease duration is bound by LEASE_SOFTLIMIT_PERIOD and 
LEASE_HARDLIMIT_PERIOD 

as a common comment,
and before each variable , variable specific comment ,

Just a thought & suggestion, please act on it, if you feel, this way is worth.

I was just wondering, there is no one till date to respond and review this...   
  
                
> Document the lease limits
> -------------------------
>
>                 Key: HDFS-4383
>                 URL: https://issues.apache.org/jira/browse/HDFS-4383
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Eli Collins
>            Priority: Trivial
>         Attachments: HDFS-4383.3.patch, HDFS-4383.patch, HDFS-4383.patch, 
> HDFS-4383.patch
>
>
> HdfsConstants.java or DFSClient/LeaseManager.java could use a comment 
> indicating the behavior of hard and soft file lease limit periods.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to