[
https://issues.apache.org/jira/browse/HDFS-4530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13588979#comment-13588979
]
Andrew Wang commented on HDFS-4530:
-----------------------------------
Hi Liang,
Patch looks good, except one minor quibble: could you revert the stylistic
change with the if/else?
I think this is one of those obviously-good patches where the lack of unit
tests is okay.
> return buffer into direct bufferPool in BlockReaderLocal as possible
> --------------------------------------------------------------------
>
> Key: HDFS-4530
> URL: https://issues.apache.org/jira/browse/HDFS-4530
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Affects Versions: 3.0.0
> Reporter: Liang Xie
> Assignee: Liang Xie
> Attachments: HDFS-4530.txt
>
>
> {code}
> public synchronized void close() throws IOException {
> dataIn.close();
> if (checksumIn != null) {
> checksumIn.close();
> }
> if (slowReadBuff != null) {
> bufferPool.returnBuffer(slowReadBuff);
> slowReadBuff = null;
> }
> if (checksumBuff != null) {
> bufferPool.returnBuffer(checksumBuff);
> checksumBuff = null;
> }
> startOffset = -1;
> checksum = null;
> }
> {code}
> If there's an IOException occurred in dataIn.close(), then the
> slowReadBuff&checksumBuff could not be returned anymore. let's make a
> trivial change to reduce this risk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
