[
https://issues.apache.org/jira/browse/HDFS-3277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13590969#comment-13590969
]
Colin Patrick McCabe commented on HDFS-3277:
--------------------------------------------
Thanks for picking this up, Andrew.
{code}
+ private void saveSecretManagerState(DataOutputStream out)
+ throws IOException {
+ int imgVersion = getLayoutVersion();
+
+ if (!LayoutVersion.supports(Feature.DELEGATION_TOKEN, imgVersion)) {
+ //SecretManagerState is not available.
+ //This must not happen if security is turned on.
+ return;
+ }
+ namesystem.saveSecretManagerState(out);
+ }
{code}
Do we need an equivalent "if" statement skipping the re-load later if we don't
support delegation tokens?
> fail over to loading a different FSImage if the first one we try to load is
> corrupt
> -----------------------------------------------------------------------------------
>
> Key: HDFS-3277
> URL: https://issues.apache.org/jira/browse/HDFS-3277
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Colin Patrick McCabe
> Assignee: Andrew Wang
> Attachments: HDFS-3277.002.patch, HDFS-3277.003.patch,
> HDFS-3277.004.patch, HDFS-3277.005.patch
>
>
> Most users store multiple copies of the FSImage in order to prevent
> catastrophic data loss if a hard disk fails. However, our image loading code
> is currently not set up to start reading another FSImage if loading the first
> one does not succeed. We should add this capability.
> We should also be sure to remove the FSImage directory that failed from the
> list of FSImage directories to write to, in the way we normally do when a
> write (as opopsed to read) fails.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
