[
https://issues.apache.org/jira/browse/HDFS-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13598385#comment-13598385
]
Jing Zhao commented on HDFS-4574:
---------------------------------
The latest patch looks good to me. I tried "mvn clean install" and the patch
can compile. Also all the snapshot-related tests passed. +1 for the patch.
BTW, we also need to add Timeout annotation to test cases in TestDiff, as
HDFS-4579 has done for other snapshot tests. We can do it either in this jira
or some later ones.
> Move Diff and EnumCounters to util package
> ------------------------------------------
>
> Key: HDFS-4574
> URL: https://issues.apache.org/jira/browse/HDFS-4574
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Attachments: a.sh, a.sh, h4574_20130308b.patch, h4574_20130308.patch,
> h4574_20130310.patch
>
>
> Diff and EnumCounters are two general utility classes. It is better to put
> them in the util package.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
