[ 
https://issues.apache.org/jira/browse/HDFS-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13599107#comment-13599107
 ] 

Arpit Agarwal commented on HDFS-4287:
-------------------------------------

Hi Chris, Sorry I did not understand the reason for this change in 
TestHdfsHelper
{code}      Path testDir = new Path("/tmp/" + testName + "-" +
        counter.getAndIncrement());
{code}

Nitpick, we can use Path.WINDOWS here and avoid adding a new dependency on 
Shell.
{code}    if (!(Shell.WINDOWS && "file:///".equals(getProxiedFSURI()))) {{code}

Rest of the changes look great!
                
> HTTPFS tests fail on Windows
> ----------------------------
>
>                 Key: HDFS-4287
>                 URL: https://issues.apache.org/jira/browse/HDFS-4287
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: webhdfs
>    Affects Versions: 3.0.0
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HDFS-4287.1.patch
>
>
> The HTTPFS tests have some platform-specific assumptions that cause the tests 
> to fail when run on Windows.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to